Skip to content

CM-25249 - Optimize the local files collection and improve the progress bar stage #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

CM-25249 - Optimize the local files collection and improve the progress bar stage #141

merged 1 commit into from
Jul 12, 2023

Conversation

@MarshalX
Copy link
Contributor

Optimization results for the path to scan with 95k files:
before ~57 sec
after ~37 sec

Results of performance investigation:

Benchmark TOP with (94882) files:
- get_all_files_walk: 0.717258458
- get_all_files_listdir: 1.4648628330000002
- get_all_files_rglob: 2.368291458

cycode-security[bot]
cycode-security bot reviewed Jul 12, 2023
View reviewed changes
@MarshalX MarshalX merged commit 9d91ff4 into main Jul 12, 2023
@MarshalX MarshalX deleted the CM-25249-optimize-local-files-collection-and-improve-the-prepare-local-files-stage-of-the-progress-bar branch July 12, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cycode-security cycode-security[bot] cycode-security[bot] left review comments

@MaorDavidzon MaorDavidzon MaorDavidzon approved these changes

@MichalBor MichalBor Awaiting requested review from MichalBor

@artem-fedorov artem-fedorov Awaiting requested review from artem-fedorov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarshalX @MaorDavidzon