-
Couldn't load subscription status.
- Fork 55
CM-22208 Add JSON output format for scan errors #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MichalBor in my last commit I use could you pls tell me what is the lowest version of python that CLI is support? |
ah, honestly I'm not sure. AFAIK we support python 3.7 as well. in general lets stick in avoiding writing a logic that is supported from specific version |
|
@artem-fedorov @MarshalX regarding the q above and for better monitoring our users python version usage - lets add python_version param to the "report" scan result API. not urgent, open a ticket to the backlog please |
@MichalBor unfortunately, it is not possible in the Python world( the project uses f-strings already, for example. f strings were added in Python 3.6 and so on. Some features were added in Python 3.7. Well, we need to specify the lowest version of Python for CLI and don't use features from higher versions. All higher versions should work fine I can do a small research to figure out if there are features in use from Python 3.7 (June 2018). I am 100% sure that at the current state of the project, it doesn't support Python lower than 3.6 (December 2016). Python 3.8 was released in Oct 2019 |
|
@MarshalX, ok, but lets support 3.7 and above for now, because we don't know what the min python version that used by the users and in the setup.py we declare we support it. regarding python version 3.6 - yep we don't support it. I don't remember exactly why, but we got an error for that specific version and preferred not to fix it since we had not users with this version at that time. |
915c5b0 to
bc960ce
Compare
|
@MichalBor I added tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
bfdbd3c to
ce281a4
Compare
|
re sign commits due to manipulation from GitHub side |
No description provided.