Skip to content

Conversation

@MarshalX
Copy link
Contributor

No description provided.

@MarshalX
Copy link
Contributor Author

rework of auth cmd planned in CM-22207

@MarshalX MarshalX force-pushed the CM-22206-add-auth-check-command branch from 7ed8987 to a13d0f4 Compare April 20, 2023 14:02
@MarshalX
Copy link
Contributor Author

@MichalBor I start thinking about the move --output option to global space. It should be cycode --output json for example. Otherwise, the option position will be dynamic and depend on the command space. There is cycode scan --output. And in this PR cycode auth --output. What do you think?

@MichalBor
Copy link
Contributor

@MichalBor I start thinking about the move --output option to global space. It should be cycode --output json for example. Otherwise, the option position will be dynamic and depend on the command space. There is cycode scan --output. And in this PR cycode auth --output. What do you think?

@MarshalX sounds good

@MarshalX
Copy link
Contributor Author

MarshalX commented Apr 24, 2023

@MichalBor the option was moved to the global space. I saved backward comparability with scan --output option too. The cyclient was refactored and all error handling happens in the base class. Also, I migrated a few direct calls of "requests" to calls of our cyclient

@MarshalX
Copy link
Contributor Author

@MichalBor I am proud to say that refactored things here were covered by unit tests in #103. Including cyclient with error handling and --output option. Let's review and merge tests first to be able to test this PR

@MarshalX MarshalX requested a review from MichalBor May 2, 2023 12:07
@MarshalX MarshalX force-pushed the CM-22206-add-auth-check-command branch from b465043 to 3c53dc2 Compare May 2, 2023 13:11
@MarshalX
Copy link
Contributor Author

MarshalX commented May 2, 2023

force pushed. re sign commit due to manipulation from GitHub side

Copy link
Contributor

@MichalBor MichalBor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

@MarshalX MarshalX requested a review from MichalBor May 2, 2023 14:03
@MarshalX MarshalX merged commit a0ca07f into main May 2, 2023
@MarshalX MarshalX deleted the CM-22206-add-auth-check-command branch May 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants