Skip to content

Add attribute expressionIsInferred to Durations #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2021
Merged

Add attribute expressionIsInferred to Durations #908

merged 3 commits into from
Mar 12, 2021

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Mar 10, 2021

Cherry-picked from #763 so that we can attack this in manageable pieces.

@coveralls
Copy link

coveralls commented Mar 10, 2021

Coverage Status

Coverage increased (+0.003%) to 92.104% when pulling e16e6fe on jacobtylerwalls:expressionIsInferred into 3fa1eb9 on cuthbertLab:master.

mscuthbert
mscuthbert approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really great. A good manageable chunk

@mscuthbert mscuthbert merged commit 30034e9 into cuthbertLab:master Mar 12, 2021
@jacobtylerwalls jacobtylerwalls deleted the expressionIsInferred branch March 12, 2021 13:22
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscuthbert mscuthbert mscuthbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobtylerwalls @coveralls @mscuthbert