feat: add "mask-type" SVG attribute (resolves #1154) #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thank you very much :) |
cure53
added a commit
that referenced
this pull request
Oct 13, 2025
* Update README.md * Update README.md * Update README.md * fix: Removed slot as SVG element, leaving it for HTML, see #1174 * feat: allow ADD_ATTR to accept a function Allow ADD_ATTR configuration option to receive a function with signature (attributeName: string, tagName: string) => boolean, enabling granular control over which attributes are allowed for specific elements. * feat: allow ADD_TAGS to accept a function Allow ADD_TAGS configuration option to receive a function with signature (tagName: string) => boolean, enabling granular control over which tags are allowed. * Allow ADD_ATTR and ADD_TAGS to accept a function (#1150) * feat: allow ADD_ATTR to accept a function Allow ADD_ATTR configuration option to receive a function with signature (attributeName: string, tagName: string) => boolean, enabling granular control over which attributes are allowed for specific elements. * feat: allow ADD_TAGS to accept a function Allow ADD_TAGS configuration option to receive a function with signature (tagName: string) => boolean, enabling granular control over which tags are allowed. * Update README.md (#1151) * feat: add "mask-type" SVG attribute (resolves #1154) (#1155) * chore: Preparing 3.3.0 release --------- Co-authored-by: Drew Neil <[email protected]> Co-authored-by: Prasad Rajandran <[email protected]>
cure53
added a commit
that referenced
this pull request
Oct 13, 2025
* Update README.md * Update README.md * Update README.md * fix: Removed slot as SVG element, leaving it for HTML, see #1174 * feat: allow ADD_ATTR to accept a function Allow ADD_ATTR configuration option to receive a function with signature (attributeName: string, tagName: string) => boolean, enabling granular control over which attributes are allowed for specific elements. * feat: allow ADD_TAGS to accept a function Allow ADD_TAGS configuration option to receive a function with signature (tagName: string) => boolean, enabling granular control over which tags are allowed. * Allow ADD_ATTR and ADD_TAGS to accept a function (#1150) * feat: allow ADD_ATTR to accept a function Allow ADD_ATTR configuration option to receive a function with signature (attributeName: string, tagName: string) => boolean, enabling granular control over which attributes are allowed for specific elements. * feat: allow ADD_TAGS to accept a function Allow ADD_TAGS configuration option to receive a function with signature (tagName: string) => boolean, enabling granular control over which tags are allowed. * Update README.md (#1151) * feat: add "mask-type" SVG attribute (resolves #1154) (#1155) * chore: Preparing 3.3.0 release --------- Co-authored-by: Drew Neil <[email protected]> Co-authored-by: Prasad Rajandran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the SVG
mask-typeattribute to the default whitelist so that it is not removed during sanitisation.Background & Context
The
mask-typeattribute indicates which mask mode, alpha or luminance, to use for the contents of the element when masking. See MDN for more information about this attribute.Tasks
mask-typeattribute to the default whitelistmask-typeattribute is not removed during sanitisationnpm run test:jsdom