Make token endpoint configurable and align with OAUTH #292
Conversation
|
I think the schema of the token response is missing? |
Should be here, right: Line 869 in 24b3858 |
|
This looks good, don't we also want to explicitly say that the token endpoint is expected to be "just OIDC"? Or what would make it different from a vanilla OIDC token endpoint? |
|
I think the difference is that there is supposed to be an authorize step before, that we skip, that is what will get you the refresh token. |
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
OK, I've added a sentence and another question. I guess some details will be cleared once we have a first implementation.
|
I think I/we need to look in to https://datatracker.ietf.org/doc/html/rfc6749 more, it feels unclear to me at this point, exactly which flow we should use. |
mickenordin
force-pushed
the
kano-auth-code
branch
from
4a4a41a to
ee0c7c8
Compare
mickenordin
changed the title
|
Ok, I think my undertanding is cleare now. I have aligned with OAUTH, but just enough so we might get away with outsourcing the token handleing to prexisting oauth libraries without imposing things that are not needed for server to server interactions |
mickenordin
force-pushed
the
kano-auth-code
branch
4 times, most recently
from
ef3f5c1 to
aa72291
Compare
This patch makes the token endpoint configurable and anligns the request with OAUTH * https://www.rfc-editor.org/rfc/rfc6749.html#section-4.1 Co-authored-by: Giuseppe Lo Presti <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
mickenordin
force-pushed
the
kano-auth-code
branch
from
aa72291 to
488fcae
Compare
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Great work Micke, this looks very promising. I have a couple of remaining questions
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
If you're happy with my additional change, this can be merged.
I have a further question but I'll open a separate issue for that.
This patch makes the token endpoint configurable and anligns the request with the requirements with OIDC/OAUTH