Fix escaping sequence names in health check

src/postgres_mcp/database_health/sequence_health_calc.py

@@ -143,6 +143,9 @@ def _parse_sequence_name(self, default_value: str) -> tuple[str, str]:
         # Remove nextval and cast parts
         clean_value = default_value.replace("nextval('", "").replace("'::regclass)", "")
         clean_value = clean_value.replace("('", "").replace("'::text)", "")
+        # We're going to feed these to sql.Identifier, so we need to remove quotes, or else
+        # they will be double quoted.
+        clean_value = clean_value.replace('"', "")
 
         # Split into schema and sequence
         parts = clean_value.split(".")

tests/unit/database_health/test_database_health_tool.py

@@ -21,7 +21,7 @@ async def setup_test_tables(sql_driver):
     conn_pool = await pool_wrapper.pool_connect()
     async with conn_pool.connection() as conn:
         # Drop existing tables if they exist
-        await conn.execute("DROP TABLE IF EXISTS test_orders")
+        await conn.execute("DROP TABLE IF EXISTS \"TestOrders\"")
         await conn.execute("DROP TABLE IF EXISTS test_customers")
         await conn.execute("DROP SEQUENCE IF EXISTS test_seq")
 
@@ -42,7 +42,7 @@ async def setup_test_tables(sql_driver):
 
         await conn.execute(
             """
-            CREATE TABLE test_orders (
+            CREATE TABLE "TestOrders" (
                 id SERIAL PRIMARY KEY,
                 customer_id INTEGER REFERENCES test_customers(id),
                 total DECIMAL NOT NULL CHECK (total >= 0),
@@ -55,23 +55,23 @@ async def setup_test_tables(sql_driver):
         # Create some indexes to test index health
         await conn.execute(
             """
-            CREATE INDEX idx_orders_customer ON test_orders(customer_id)
+            CREATE INDEX idx_orders_customer ON "TestOrders"(customer_id)
             """
         )
         await conn.execute(
             """
-            CREATE INDEX idx_orders_status ON test_orders(status)
+            CREATE INDEX idx_orders_status ON "TestOrders"(status)
             """
         )
         await conn.execute(
             """
-            CREATE INDEX idx_orders_created ON test_orders(created_at)
+            CREATE INDEX idx_orders_created ON "TestOrders"(created_at)
             """
         )
         # Create a duplicate index to test duplicate index detection
         await conn.execute(
             """
-            CREATE INDEX idx_orders_customer_dup ON test_orders(customer_id)
+            CREATE INDEX idx_orders_customer_dup ON "TestOrders"(customer_id)
             """
         )
 
@@ -88,7 +88,7 @@ async def setup_test_tables(sql_driver):
 
         await conn.execute(
             """
-            INSERT INTO test_orders (customer_id, total, status)
+            INSERT INTO "TestOrders" (customer_id, total, status)
             SELECT
                 (random() * 99)::int + 1,  -- Changed to ensure IDs are between 1 and 100
                 (random() * 1000)::decimal,
@@ -103,15 +103,15 @@ async def setup_test_tables(sql_driver):
 
         # Run ANALYZE to update statistics
         await conn.execute("ANALYZE test_customers")
-        await conn.execute("ANALYZE test_orders")
+        await conn.execute("ANALYZE \"TestOrders\"")
 
 
 async def cleanup_test_tables(sql_driver):
     pool_wrapper = sql_driver.connect()
     conn_pool = await pool_wrapper.pool_connect()
     try:
         async with conn_pool.connection() as conn:
-            await conn.execute("DROP TABLE IF EXISTS test_orders")
+            await conn.execute("DROP TABLE IF EXISTS \"TestOrders\"")
             await conn.execute("DROP TABLE IF EXISTS test_customers")
             await conn.execute("DROP SEQUENCE IF EXISTS test_seq")
     finally: