Skip to content

Fix ENV#each #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2018
Merged

Fix ENV#each #6499

merged 2 commits into from
Aug 7, 2018

Conversation

@straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Aug 7, 2018 •
edited
Loading

In #6333 ENV.each yields String, String instead of {String, String}. That messes up all the Enumerable methods, including Enumerable#first which is used by Enumerable#to_h.

I also added a few ensures to delete ENV variables added by each spec.

Fixes #6253 (the second issue in that thread)

@straight-shoota straight-shoota changed the title Fix ENV Fix ENV#each Aug 7, 2018
@RX14 RX14 merged commit f9569e7 into crystal-lang:master Aug 7, 2018
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels Aug 7, 2018
@RX14 RX14 added this to the 0.26.0 milestone Aug 7, 2018
@straight-shoota straight-shoota deleted the jm/fix/env-to_h branch August 7, 2018 10:50
@Sija Sija mentioned this pull request Aug 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhass jhass jhass approved these changes

@RX14 RX14 RX14 approved these changes

Assignees

No one assigned

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

3 participants

@straight-shoota @jhass @RX14