-
Notifications
You must be signed in to change notification settings - Fork 20
Add XWingDraft06 KEM support to hpke-rs, and replace evercrypt provider with new libcrux provider
#72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
XWingDraft06 KEM support to hpke-rs, and replace evercrypt_provider with new libcrux_providerXWingDraft06 KEM support to hpke-rs, and replace evercrypt provider with new libcrux provider
keks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it goes in exactly the right direction! I left a few comments, including an idea where the CI failure might come from.
a934060 to
323f152
Compare
|
Looks like coverage fails because of rust-lang/rust#131829 |
|
In OpenMLS we use the new cli options, they should work here, too: https://github.com/openmls/openmls/blob/main/.github/workflows/coverage.yml |
|
The |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 44.65% 44.32% -0.33%
==========================================
Files 15 16 +1
Lines 3630 4708 +1078
==========================================
+ Hits 1621 2087 +466
- Misses 2009 2621 +612
🚀 New features to boost your workflow:
|
|
Can you add the changes from here to the changelog? |
keks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
This PR adds support to the
hpke-rsandhpke-rs-cryptocrates forXWingDraft06KEM, and includes updates to theHpkeCryptotrait that take this change into account.It also replaces the Evercrypt provider crate (
hpke-rs-evercrypt) with a new Libcrux provider crate (hpke-rs-libcrux), which is built on pure Rust dependencies.Additionally, this PR upgrades
rand=0.8->rand=0.9for all crates in the project (with the exception that, for the Rust crypto providerhpke-rs-rust-crypto, therand=0.8traits are implemented, for compatibility with dependencies)Currently, this branch depends on new versions of libcrux dependencies in the main branch.
Clippy lints are also applied.
Resolves #71