Skip to content

Conversation

@bobby-lin-cdc
Copy link
Contributor

@bobby-lin-cdc bobby-lin-cdc commented Apr 15, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to use specific commit SHAs for all action references instead of version tags, improving reliability and reproducibility of CI/CD processes.
    • No changes to workflow logic or user-facing features.

@bobby-lin-cdc bobby-lin-cdc requested a review from a team as a code owner April 15, 2025 07:57
@bobby-lin-cdc bobby-lin-cdc requested review from calvinaco and mmsqe and removed request for a team April 15, 2025 07:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 15, 2025

Walkthrough

This update modifies multiple GitHub Actions workflow files to replace floating version tags of various actions with explicit commit SHA references. The affected actions include those for Nix installation, Cachix, Codecov, markdown link checking, release management, security scanning, and more. These changes are applied consistently across all relevant workflow files, ensuring that each action now references a specific commit rather than a tag or branch. No workflow logic, control flow, or environment variables are altered; only the action references are updated for greater determinism and reproducibility.

Changes

Files Change Summary
.github/workflows/build.yml, .github/workflows/test.yml Updated action references (cachix/install-nix-action, tj-actions/changed-files, cachix/cachix-action, codecov/codecov-action) from version tags to specific commit SHAs. No logic changes.
.github/workflows/lint.yml Updated action references (cachix/install-nix-action, tj-actions/changed-files, cachix/cachix-action) from version tags to commit SHAs across all jobs. No logic changes.
.github/workflows/container.yml Updated cachix/install-nix-action and cachix/cachix-action from version tags to commit SHAs. No other changes.
.github/workflows/linkchecker.yml Updated gaurav-nelson/github-action-markdown-link-check from tag to commit SHA.
.github/workflows/gosec.yml Updated technote-space/get-diff-action and informalsystems/gosec from tags/branches to commit SHAs.
.github/workflows/proto.yml Updated technote-space/get-diff-action and numtide/clean-git-action from tags/branches to commit SHAs in all jobs.
.github/workflows/release.yml Updated cachix/install-nix-action, cachix/cachix-action, softprops/action-gh-release, and apple-actions/import-codesign-certs from tags to commit SHAs.
.github/workflows/sims.yml Updated tspascoal/get-user-teams-membership and octokit/request-action from tags/branches to commit SHAs.

Possibly related PRs

Suggested reviewers

  • JayT106
  • leejw51crypto
  • yihuang

Poem

🐇 In the burrow where the workflows play,
We’ve pinned each step to keep bugs away.
No drifting tags to cause dismay,
Just solid SHAs to guide the way.
CI hops smooth, no fear or fright,
With commits locked tight, we code just right!
🌿✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f987528 and 9ee1612.

📒 Files selected for processing (4)
  • .github/workflows/build.yml (7 hunks)
  • .github/workflows/linkchecker.yml (1 hunks)
  • .github/workflows/lint.yml (3 hunks)
  • .github/workflows/test.yml (4 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/lint.yml
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/workflows/test.yml
  • .github/workflows/linkchecker.yml
  • .github/workflows/build.yml
⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: integration_tests (gas)
  • GitHub Check: integration_tests (slow)
  • GitHub Check: integration_tests (upgrade)
  • GitHub Check: integration_tests (gov)
  • GitHub Check: integration_tests (ica)
  • GitHub Check: integration_tests (ibc_update_client)
  • GitHub Check: integration_tests (ibc_timeout)
  • GitHub Check: integration_tests (ibc_rly_gas)
  • GitHub Check: integration_tests (ibc_rly_evm)
  • GitHub Check: integration_tests (ibc)
  • GitHub Check: integration_tests (unmarked)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mmsqe mmsqe enabled auto-merge April 15, 2025 07:59
@mmsqe mmsqe added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 0ac7f97 Apr 15, 2025
32 checks passed
mmsqe added a commit to mmsqe/cronos that referenced this pull request Apr 16, 2025
Signed-off-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>
mmsqe added a commit that referenced this pull request May 2, 2025
* Problem: changelog is outdated

* bump changed-files

* pin gha hash (#1792)

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>

* fix resolve

---------

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: bobby-lin-cdc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants