Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Aug 7, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1125 (4e5464b) into main (55e5662) will increase coverage by 1.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   46.24%   47.60%   +1.36%     
==========================================
  Files          82       66      -16     
  Lines        7409     6006    -1403     
==========================================
- Hits         3426     2859     -567     
+ Misses       3619     2832     -787     
+ Partials      364      315      -49     

see 23 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review August 7, 2023 09:23
@mmsqe mmsqe requested a review from a team as a code owner August 7, 2023 09:23
@mmsqe mmsqe requested review from calvinaco and yihuang and removed request for a team August 7, 2023 09:23
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe enabled auto-merge August 8, 2023 02:38
@mmsqe mmsqe added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 8, 2023
@mmsqe mmsqe added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@mmsqe mmsqe added this pull request to the merge queue Aug 8, 2023
Merged via the queue into crypto-org-chain:main with commit 082feca Aug 8, 2023
mmsqe added a commit to mmsqe/cronos that referenced this pull request Aug 8, 2023
…rypto-org-chain#1125)

* Problem: feeibc, evm and feemarket gensis migrate is broken

* make use of sdk

* add test

* fix gravity genesis

* update deps

* add change doc

* update deps

* Update CHANGELOG.md

Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>

---------

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]>
yihuang pushed a commit that referenced this pull request Aug 10, 2023
…1125) (#1124)

* Problem: feeibc, evm and feemarket gensis migrate is broken

* make use of sdk

* add test

* fix gravity genesis

* update deps

* add change doc

* update deps

* Update CHANGELOG.md




---------

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants