Skip to content

Conversation

@yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 4, 2023

Solution:

  • wait for async commit to finish to make sure catching up to latest state.

thanks for @yzang2019 's diagnose.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- wait for async commit to finish to make sure catching up to latest state.
@yihuang yihuang requested a review from a team as a code owner August 4, 2023 11:20
@yihuang yihuang requested review from JayT106 and mmsqe and removed request for a team August 4, 2023 11:20
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe August 4, 2023 13:51
@yihuang yihuang enabled auto-merge August 4, 2023 14:04
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1123 (2618dca) into main (496ce7e) will increase coverage by 0.04%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   46.19%   46.24%   +0.04%     
==========================================
  Files          82       82              
  Lines        7392     7409      +17     
==========================================
+ Hits         3415     3426      +11     
- Misses       3616     3619       +3     
- Partials      361      364       +3     
Files Changed Coverage Δ
memiavl/db.go 58.54% <47.05%> (+0.18%) ⬆️

@yihuang yihuang added this pull request to the merge queue Aug 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2023
@yihuang yihuang added this pull request to the merge queue Aug 5, 2023
Merged via the queue into crypto-org-chain:main with commit 55e5662 Aug 5, 2023
@yihuang yihuang deleted the fix-memiavl branch August 5, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants