Make config vectors optional. #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
force-pushed
the
config_array
branch
from
67b20fd to
fc0a731
Compare
|
If we use optional variables for config options, then this is required for us to be able to differentiate if a variable is provided and empty, or simply not provided. For example, if we have: [build.env]
passthrough = []We currently cannot differentiate it from: [build.env]When merging, this means we do not know if we need to overwrite the value, or not. What this does is it changes all |
Emilgardis
requested changes
Jun 15, 2022
Alexhuszagh
force-pushed
the
config_array
branch
from
fc0a731 to
462e40a
Compare
|
Both resolved, I made it so there's an |
Emilgardis
requested changes
Jun 15, 2022
Allows us to differentiate between an empty array and an array that was not provided when merging config files. cross-rs#754 (comment) Required for cross-rs#754.
Alexhuszagh
force-pushed
the
config_array
branch
from
462e40a to
830f836
Compare
|
Build succeeded: |
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to differentiate between an empty array and an array that was not provided when merging config files.
#754 (comment)
Required for #754.