Skip to content

Conversation

@fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Jul 6, 2023

Docker build issue identified in https://github.com/crim-ca/weaver/actions/runs/5476798191/jobs/9974868828?pr=542

Fixes

Since the CI fails with either combination of those fixes individually (docker build fail or lint checks fail), combine them all in one.

@fmigneault fmigneault added the feature/docker Issue related to Docker application package execution. label Jul 6, 2023
@fmigneault fmigneault self-assigned this Jul 6, 2023
@github-actions github-actions bot added the ci/doc Issue related to documentation of the package label Jul 6, 2023
@github-actions github-actions bot added ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Jul 7, 2023
@fmigneault fmigneault changed the title fix docker build of weaver-worker CI fixes Jul 7, 2023
@fmigneault fmigneault force-pushed the fix-docker-worker branch from a6befbe to f0d9aff Compare July 7, 2023 15:37
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #543 (a6befbe) into master (fd1e68e) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

❗ Current head a6befbe differs from pull request most recent head f0d9aff. Consider uploading reports for the commit f0d9aff to get more accurate results

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   84.39%   84.38%   -0.01%     
==========================================
  Files          79       79              
  Lines       17596    17601       +5     
  Branches     2670     2670              
==========================================
+ Hits        14850    14853       +3     
- Misses       2017     2019       +2     
  Partials      729      729              
Impacted Files Coverage Δ
weaver/database/mongodb.py 89.53% <ø> (ø)
weaver/formats.py 88.44% <ø> (ø)
weaver/xml_util.py 100.00% <ø> (ø)
weaver/utils.py 82.86% <71.42%> (-0.08%) ⬇️
weaver/owsexceptions.py 75.14% <75.00%> (ø)
weaver/datatype.py 78.81% <100.00%> (ø)
weaver/processes/utils.py 79.70% <100.00%> (ø)
weaver/processes/wps_process_base.py 84.51% <100.00%> (ø)
weaver/wps/service.py 84.44% <100.00%> (ø)
weaver/wps_restapi/colander_extras.py 82.53% <100.00%> (ø)

@fmigneault fmigneault merged commit fb7bda6 into master Jul 7, 2023
@fmigneault fmigneault deleted the fix-docker-worker branch July 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/docker Issue related to Docker application package execution. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants