Skip to content

Add DeepSeek V3.1 thinking mode support #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 48 commits into
base: master
Choose a base branch
from
Draft

Add DeepSeek V3.1 thinking mode support #6

wants to merge 48 commits into from
+457 −4

Conversation

createthis
Copy link
Owner

just for my own use

@openhands-agent
Add DeepSeek V3.1 thinking mode support
0d96944 
- Added COMMON_CHAT_FORMAT_DEEPSEEK_V3_1 enum value
- Created common_chat_params_init_deepseek_v3_1() function (currently uses R1 implementation)
- Created common_chat_parse_deepseek_v3_1() function that handles V3.1 thinking format:
  - Extracts reasoning content before '</think>' tag into reasoning_content
  - Extracts regular content after '</think>' tag into content
  - No opening '<think>' tag in V3.1 format
- Added detection logic for V3.1 templates based on pattern: 'message['prefix'] is defined and message['prefix'] and thinking'
- Added V3.1 case to parsing switch statement

This addresses the issue where V3.1 outputs reasoning content followed by '</think>' and then regular content without the opening '<think>' tag.
@createthis createthis self-assigned this Aug 22, 2025
@createthis createthis mentioned this pull request Aug 22, 2025
Open
4 tasks
@createthis
Try using try_find_literal instead of regex
c50d887
@createthis
passing test
3f319aa
@createthis
Revert "Try using try_find_literal instead of regex"
79f7ca3 
This reverts commit c50d887.
@createthis
Remove unnecessary change
0d959ba
@createthis
Remove comment
6223c1c
@createthis
Add code to handle non-thinking mode.
0d372f4
@createthis
Try to set message['prefix'] when thinking is enabled.
f0da116
@createthis
This fixes reasoning, but breaks normal content. We need state in the
56f7e38 
chat parser.
@createthis
DeepSeek V3.1 thinking is now the default. Disable with `--reasoning-…
f4f0ddb 
…budget 0`.
@createthis
Simplify (DeepSeek V3.1 reasoning)
f7d2ee9
@createthis
Fix sign inversion bug
7ac92ca
@createthis
Add some tool calling code (not working).
be0b2b8
@createthis
Tool calls working in non-reasoning mode.
776d95b
@createthis
Attempt a unit test for tool call parsing.
a32cad1
@createthis
Passing test
52d5488
@createthis
Add tests for both happy path and broken fenced DeepSeek V3.1 tool ca…
a839be7 
…ll variants.
@createthis
Passing DeepSeek V3.1 tool call tests, but model is not working.
6ade60e
@createthis
Revert assistance response prefill change. Not my monkeys.
79d4812
@createthis
Add fenced_thinking unit test variant. Passes, but thinking tool calling
36b047c 
still isn't working for some reason.
@createthis
Tests pass in reasoning mode. Also e2e tool test passes.
bdfa87f
@createthis
Make a copy of the parse_json_tool_calls function for deepseek-v3.1 so
0e36761 
as to not accidentally introduce regressions.
@createthis
Merge pull request #7 from createthis/deepseek_3_1_thinking_mode_danger
4cb47f3 
Tool calls work in thinking and non-thinking modes. However, I've introduced a regression in streaming mode where reasoning content initially comes through as regular content. I need to think about how to deal with this long term.
@createthis
Fix thinking_forced_open logic. tool calling broken. Need to add another
ab22c76 
test case.
createthis and others added 20 commits August 26, 2025 14:22
@createthis
That's what I get for cargo culting a newline.
4a2d17d
@createthis
Add multi tool call test for deepseek v3.1 non-reasoning
b2d57ce
@createthis
Merge branch 'master' into deepseek_3_1_thinking_mode
f422fe7
@createthis
Move test, remove .gitignore change
7dc19e8
@createthis
Place deepseek-v3.1 reasoning test directly into existing reasoning
380146e 
function per CISC's request.
@createthis
Address whitespace CI failure.
9056707
@createthis
Merge two assert_equals per CISC's request.
a406d6a
@createthis
Add DeepSeek-V3.1 tests to tests/test-chat.cpp per CISC's request.
ec984da
@createthis
Merge branch 'master' into deepseek_3_1_thinking_mode
92003d7
@createthis
Merge deepseek V3.1 and regular parse_json_tool_calls() function
f661dbe 
behaviors by adding optional update_cursor argument.
@createthis @CISC
Update tests/test-chat-parser.cpp
12b013f 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
800af00 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
80a7e1c 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
155852a 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
e587808 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
ac6ed1e 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
3843d94 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
6773708 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis @CISC
Update tests/test-chat-parser.cpp
befa31c 
Co-authored-by: Sigbjørn Skjæret <[email protected]>
@createthis
DeepSeek V3.1 fix reasoning_format none
7795594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@createthis createthis

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@createthis @openhands-agent