feat: support clang-tidy v21 #100
Conversation
shenxianpeng
changed the title
clang-tidy==21.1.0
github-actions
bot
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 3 3
Lines 145 145
=======================================
Hits 137 137
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. WalkthroughUpdates Clang tool version references from 20 → 21 across docs, config, supported-version lists, and tests; adds 21.1.0 to supported clang-format/clang-tidy and updates the optional clang-tidy dependency pin. Changes
Sequence Diagram(s)No control-flow or feature-level behavior changes were introduced; sequence diagrams not applicable. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
testing/pre-commit-config-version.yaml (1)
43-43: Remove/adjust stale comment: 21 is now supported.The inline comment contradicts the PR goal and the rest of the repo updates that add clang-tidy 21.1.0 support.
- args: [--checks=.clang-tidy, --version=21] # clang-tidy does not support version 21 + args: [--checks=.clang-tidy, --version=21]cpp_linter_hooks/util.py (1)
122-123: The tests for_resolve_versiondon’t include cases for input"21"mapping to"21.1.0"or for exact"21.1.0". Please add parametrized tests intests/test_util.pyunder bothtest_resolve_version_clang_formatandtest_resolve_version_clang_tidyto cover:
- user_input
"21"→ expected"21.1.0"- user_input
"21.1.0"→ expected"21.1.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
README.md(1 hunks)cpp_linter_hooks/util.py(1 hunks)pyproject.toml(1 hunks)testing/pre-commit-config-version.yaml(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
pyproject.toml (1)
tests/test_util.py (1)
test_get_version_from_dependency_success(101-123)
cpp_linter_hooks/util.py (1)
tests/test_util.py (6)
test_version_lists_not_empty(424-429)test_resolve_version_clang_tidy(195-198)test_get_version_from_dependency_success(101-123)test_default_versions(415-420)test_get_runtime_version_clang_format(203-209)test_get_runtime_version_clang_tidy(213-219)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test (3.14)
- GitHub Check: Run benchmarks
🔇 Additional comments (3)
pyproject.toml (1)
51-53: Confirmed 21.1.0 wheels published for all major platforms
Both clang-format and clang-tidy v21.1.0 have universal py2.py3 binaries across macOS (x86_64, arm64), Linux (manylinux / musllinux on x86_64, i686, aarch64, ppc64le, s390x, armv7l), Windows (win32, win_amd64, win_arm64) plus source sdists—pin is safe.README.md (1)
157-161: Docs updated to v21 — LGTM.Examples now align with the new supported version.
cpp_linter_hooks/util.py (1)
107-108: Add clang-format 21.1.0 — LGTM.Matches the new default/tooling support.
CodSpeed Performance ReportMerging #100 will degrade performances by 10.92%Comparing Summary
Benchmarks breakdown
|
|
shenxianpeng
changed the title
clang-tidy==21.1.0
Summary by CodeRabbit