Skip to content

Conversation

@kidkidkid
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 87.17949% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ackend/modules/observability/infra/config/trace.go 43.75% 6 Missing and 3 partials ⚠️
backend/modules/observability/infra/rpc/tag/tag.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   68.01%   68.01%   -0.01%     
==========================================
  Files         568      568              
  Lines       50478    50502      +24     
==========================================
+ Hits        34335    34351      +16     
- Misses      13473    13479       +6     
- Partials     2670     2672       +2     
Flag Coverage Δ
unittests 68.01% <87.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/observability/application/trace.go 69.87% <100.00%> (+0.45%) ⬆️
...n/trace/service/trace/span_filter/prompt_filter.go 94.54% <100.00%> (-0.29%) ⬇️
...service/trace/span_processor/platform_processor.go 75.00% <100.00%> (-1.93%) ⬇️
backend/modules/observability/infra/rpc/tag/tag.go 0.00% <0.00%> (ø)
...ackend/modules/observability/infra/config/trace.go 87.27% <43.75%> (-7.52%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5774a73...71ab060. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid force-pushed the feat/get_trace_refactor branch from 58e7e16 to 7d5d29e Compare October 31, 2025 10:01
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aime Review: Identified 1 Must-Fix and several Should-Fix/Suggestions in concurrency and configuration handling. Please see inline comments for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants