-
Notifications
You must be signed in to change notification settings - Fork 690
[feat] open api eval #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[feat] open api eval #258
Conversation
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
(LogID: 2025092312090101009108820949935E9) Co-Authored-By: Coda <[email protected]>
…ationSet, GetEvaluationSet, ListEvaluationSets (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
… convertor (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…ic to separate methods (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…rate methods (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…unified method parameter (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…error tracking (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…DTO/xxxDTO2DO convention (LogID: 202509281948170100910941219983125) Co-Authored-By: Coda <[email protected]>
…rchitecture (LogID: 20250928231227010091094121028E1E4) Co-Authored-By: Coda <[email protected]>
(LogID: 202510222206430100910941210024144) Co-Authored-By: Coda <[email protected]>
Change-Id: I0ea45eaca2e39b95fc53e4108397ac5e5ecacf48
(LogID: 20251026112148192168001003073C0F4) Co-Authored-By: Coda <[email protected]>
Change-Id: Id1c3b2d366c4c0de0f2916b531f4d8c6ac2b2734
(LogID: 202510261432441921680010035228DDE) Co-Authored-By: Coda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary: This PR introduces OpenAPI evaluation endpoints and supporting domain changes. I found two critical must-fix issues that will break the flow:
- Handler
ReportEvalTargetInvokeResultdoes not invoke the service and returns an empty response, dropping incoming results. DatasetRPCAdapter.BatchUpdateDatasetItemsis unimplemented and panics, causingBatchUpdateEvaluationSetItemsOApito crash.
Additionally, there are should-fix improvements: guard against nil in ReportEvalTargetInvokeResult_ when computing latency, and avoid logging full payloads; also fix a misleading error message and a minor IDL comment typo. See inline comments for exact locations and suggested fixes.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: