[deprecated][fix][infra]change CheckAndDeductOptimizationBenefit struct to fit special task #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imizationBenefit Co-Authored-By: Coda <[email protected]>
…imizationBenefit Co-Authored-By: Coda <[email protected]>
…/coze-loop into feat/optimize_task_prompt_pilot
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
…t execution trace control
…imizationBenefit Co-Authored-By: Coda <[email protected]>
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
…t execution trace control
…/coze-loop into feat/optimize_task_prompt_pilot
This reverts commit ea002c3.
…imizationBenefit Co-Authored-By: Coda <[email protected]>
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
…t execution trace control
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
This reverts commit ea002c3.
…/coze-loop into feat/optimize_task_prompt_pilot
…imizationBenefit Co-Authored-By: Coda <[email protected]>
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
…t execution trace control
…ontrol Generated with Coda Co-Authored-By: Coda <[email protected]>
This reverts commit ea002c3.
# Conflicts: # backend/infra/external/benefit/benifit.go # backend/infra/external/benefit/noop.go
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 65.66% 65.69% +0.02%
==========================================
Files 504 507 +3
Lines 57307 57718 +411
==========================================
+ Hits 37629 37915 +286
- Misses 17103 17197 +94
- Partials 2575 2606 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
CozeLoop
suggested changes
Oct 23, 2025
There was a problem hiding this comment.
Summary: Requesting changes due to numeric type inconsistency (float64 vs int64) for resource points and enum robustness/naming for When. See inline comments.
- Must-Fix: Use integer/decimal type for resource points consistently across check/deduct paths to avoid precision drift.
- Should-Fix: Rename and validate enum
When(suggestOptPhasewithValid()), avoid ambiguous zero value. - Suggestion: Mark deprecated API with
Deprecated:for tooling support.
Thanks for the clear scope and minimal diff. Once addressed, the API surface will be more robust and consistent.
biwang75678
approved these changes
Oct 23, 2025
xueyizheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: change a benefit struct to fit special task
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes: