Improve in-proc collector logs #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Sep 17, 2019
| EqtTrace.Error("{0}: Failed to unload module with error: {1}", CoverletConstants.InProcDataCollectorName, ex); | ||
| } | ||
|
|
||
| _eqtTrace.Error("{0}: Failed to unload module with error: {1}", CoverletConstants.InProcDataCollectorName, ex); |
Collaborator
Author
There was a problem hiding this comment.
@vagisha-nidhi I removed check EqtTrace.IsErrorEnabled here and on other place because I don't understand how I can define switch level using command dotnet test --collect:"Xplat code coverage" --diag:"diag.txt"
Again they're not used in all other place(out-of-proc collector), are used only for Info and in one place only for verbose.
Can you explain how it works?Or how can I pass log level for EqtTrace to dotnet test
Collaborator
Author
There was a problem hiding this comment.
@vagisha-nidhi I merged...let me know if it's a problem.
petli
approved these changes
Sep 18, 2019
tonerdo
approved these changes
Sep 21, 2019
src/coverlet.collector/InProcDataCollection/CoverletInProcDataCollector.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in-proc collector log
cc: @tonerdo @petli