Relative paths lcov #1004
Relative paths lcov #1004
Conversation
…nto helper class (coverlet-coverage#263) Refactored functions to determine base paths from CoberturaReporter into helper class
…in report (coverlet-coverage#263) Updated LcovReporter to include only relative paths for source files in report
…into relative-paths-lcov
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MarcoRossignoli
added
the
tenet-reporters
|
@phaniva please sign the CLA. I'll take a look asap |
|
@MarcoRossignoli I have signed the CLA. Not sure if you received a notification automatically |
|
@phaniva yep I see, bit busy this period, I'll take a look asap. |
|
|
||
| namespace Coverlet.Core.Helpers | ||
| { | ||
| internal class FilePathHelper : IFilePathHelper |
There was a problem hiding this comment.
I think that extract a service is too much for a path helper...I mean we won't inject different implementation there are no different way to get that path from file system.
Should be enough add a new base class abstract ReporterBase and add this two method as protected and inherit the reporter that needs this logic.
There was a problem hiding this comment.
So only the reporter classes that need this behavior will inherit from ReporterBase and rest of them will continue to implement IReporter?
Why not inherit every reporter class from ReporterBase to keep things consistent?
There was a problem hiding this comment.
Ok I won't oppose, the important things is that we have less code as possible to maintain, let's go for base class inherited by reporters
There was a problem hiding this comment.
Cool. I am going to close this pr and open a new one with base class design.
Here is the new pr.
#1120
3 participants
Please review this design to see if it addresses the requirement. I changed it so that we can enable relative directory option for all report formats but only changed it for lcov for now.