move unique identifier generation to Coverage class

Author: tonerdo

src/coverlet.core/Coverage.cs

@@ -14,35 +14,35 @@ public class Coverage
         private string _module;
         private string _identifier;
         private string[] _filters;
-        private string[] _rules;
+        private string[] _excludes;
         private List<InstrumenterResult> _results;
 
         public string Identifier
         {
             get { return _identifier; }
         }
 
-        public Coverage(string module, string[] filters, string[] rules)
+        public Coverage(string module, string[] filters, string[] excludes)
         {
             _module = module;
             _filters = filters;
-            _rules = rules;
+            _excludes = excludes;
             _identifier = Guid.NewGuid().ToString();
             _results = new List<InstrumenterResult>();
         }
 
         public void PrepareModules()
         {
             string[] modules = InstrumentationHelper.GetCoverableModules(_module);
-            string[] excludedFiles =  InstrumentationHelper.GetExcludedFiles(_rules);
+            string[] excludes =  InstrumentationHelper.GetExcludedFiles(_excludes);
             _filters = _filters?.Where(f => InstrumentationHelper.IsValidFilterExpression(f)).ToArray();
 
             foreach (var module in modules)
             {
                 if (InstrumentationHelper.IsModuleExcluded(module, _filters))
                     continue;
 
-                var instrumenter = new Instrumenter(module, _identifier, _filters, excludedFiles);
+                var instrumenter = new Instrumenter(module, _identifier, _filters, excludes);
                 if (instrumenter.CanInstrument())
                 {
                     InstrumentationHelper.BackupOriginalModule(module, _identifier);

src/coverlet.core/Helpers/InstrumentationHelper.cs

@@ -166,15 +166,15 @@ public static bool IsTypeExcluded(string module, string type, string[] filters)
         public static bool IsLocalMethod(string method)
             => new Regex(WildcardToRegex("<*>*__*|*")).IsMatch(method);
 
-        public static string[] GetExcludedFiles(string[] rules)
+        public static string[] GetExcludedFiles(string[] excludes)
         {
             const string RELATIVE_KEY = nameof(RELATIVE_KEY);
             string parentDir = Directory.GetCurrentDirectory();
 
-            if (rules == null || !rules.Any()) return Array.Empty<string>();
+            if (excludes == null || !excludes.Any()) return Array.Empty<string>();
 
             var matcherDict = new Dictionary<string, Matcher>() { { RELATIVE_KEY, new Matcher() } };
-            foreach (var excludeRule in rules)
+            foreach (var excludeRule in excludes)
             {
                 if (Path.IsPathRooted(excludeRule))
                 {

src/coverlet.msbuild.tasks/InstrumentationTask.cs

@@ -40,10 +40,10 @@ public override bool Execute()
         {
             try
             {
-                var rules = _excludeByFile?.Split(',');
+                var excludes = _excludeByFile?.Split(',');
                 var filters = _exclude?.Split(',');
 
-                _coverage = new Coverage(_path, filters, rules);
+                _coverage = new Coverage(_path, filters, excludes);
                 _coverage.PrepareModules();
             }
             catch (Exception ex)