generate unique identifier within Coverage class

Author: tonerdo

src/coverlet.core/Coverage.cs

@@ -17,12 +17,17 @@ public class Coverage
         private string[] _rules;
         private List<InstrumenterResult> _results;
 
-        public Coverage(string module, string identifier, string[] filters, string[] rules)
+        public string Identifier
+        {
+            get { return _identifier; }
+        }
+
+        public Coverage(string module, string[] filters, string[] rules)
         {
             _module = module;
-            _identifier = identifier;
             _filters = filters;
             _rules = rules;
+            _identifier = Guid.NewGuid().ToString();
             _results = new List<InstrumenterResult>();
         }
 

src/coverlet.msbuild.tasks/InstrumentationTask.cs

@@ -43,7 +43,7 @@ public override bool Execute()
                 var rules = _excludeByFile?.Split(',');
                 var filters = _exclude?.Split(',');
 
-                _coverage = new Coverage(_path, Guid.NewGuid().ToString(), filters, rules);
+                _coverage = new Coverage(_path, filters, rules);
                 _coverage.PrepareModules();
             }
             catch (Exception ex)

test/coverlet.core.tests/CoverageTests.cs

@@ -16,9 +16,8 @@ public void TestCoverage()
         {
             string module = GetType().Assembly.Location;
             string pdb = Path.Combine(Path.GetDirectoryName(module), Path.GetFileNameWithoutExtension(module) + ".pdb");
-            string identifier = Guid.NewGuid().ToString();
 
-            var directory = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), identifier));
+            var directory = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString()));
 
             File.Copy(module, Path.Combine(directory.FullName, Path.GetFileName(module)), true);
             File.Copy(pdb, Path.Combine(directory.FullName, Path.GetFileName(pdb)), true);
@@ -28,7 +27,7 @@ public void TestCoverage()
             // Since Coverage only instruments dependancies, we need a fake module here
             var testModule = Path.Combine(directory.FullName, "test.module.dll");
 
-            var coverage = new Coverage(testModule, identifier, Array.Empty<string>(), Array.Empty<string>());
+            var coverage = new Coverage(testModule, Array.Empty<string>(), Array.Empty<string>());
             coverage.PrepareModules();
 
             var result = coverage.GetCoverageResult();