Skip to content

RFC-0075: Faster Failover and Configuration Push #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

RFC-0075: Faster Failover and Configuration Push #123

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6914a45
RFC-0075: initial draft
avsej Jun 14, 2023
3a2465e
Merge remote-tracking branch 'origin/master' into 0075-faster-failove…
avsej Jun 27, 2023
41b63ec
Update
avsej Jun 27, 2023
0a4590b
note about polling when brief push is not available
avsej Jun 27, 2023
1a3cfe3
clarify client-side deduplication in check list
avsej Jun 27, 2023
92753ec
highlight that requests for configs with old revisions should be ignored
avsej Jun 27, 2023
41538e6
add clarification on how KV engine deduplicates config payloads
avsej Jun 27, 2023
af58f5a
update NotMyVbucket workflow, fixed typos
avsej Jun 27, 2023
7883de4
Cover mixed mode case and push workflow
avsej Jun 27, 2023
019b243
note about errors from HELLO operation
avsej Jul 10, 2023
040406a
clarify HELLO error handling
avsej Jul 10, 2023
123bb43
note about OoO and NMV deduplication
avsej Jul 10, 2023
c08136a
fix point 3 in checklist
avsej Jul 13, 2023
9dc0ad3
update encoding diagrams
avsej Jul 13, 2023
1270f30
typos in packet layout
avsej Aug 4, 2023
05dcb0e
Update rfc/0075-faster-failover-and-configuration-push.md
avsej Aug 4, 2023
af87a87
Update rfc/0075-faster-failover-and-configuration-push.md
avsej Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rfc/0075-faster-failover-and-configuration-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,11 @@ sequenceDiagram
6. [OPTIONAL] `SnappyEverywhere` (`0x13`). The SDK should be ready that KV engine might send Snappy-compressed payload with any
of the response types (including push notifications). Check datatype `SNAPPY` (`0x02`).

7. SDK should be able to handle errors from HELLO. It is not critical right now, but in theory it might be happening in
future. For example, Sending `ClustermapChangeNotificationBrief` (`0x1f`) without `Duplex` (`0x0c`) will trigger
response with the status code `Einval` (`0x04`) and body `{"error":{"context":"ClustermapChangeNotificationBrief needs Duplex"}}`.
See [hello\_packet\_executor.cc][kv-engine-hello-error] for more details.

# Open Questions

1. TBD
Expand Down Expand Up @@ -362,3 +367,4 @@ sequenceDiagram
[rfc-0005]: /rfc/0005-vbucket-retries.md
[rfc-0024]: /rfc/0024-fast-failover.md
[rfc-0048]: /rfc/0048-sdk3-bootstrapping.md
[kv-engine-hello-error]: https://github.com/couchbase/kv_engine/blob/fc4e8f7a71609687302f3f54d2f5052f86105400/daemon/protocol/mcbp/hello_packet_executor.cc#L147-L152