auth test: refactor for better error

[torcolvin]

Refactor tests in prep for CBG-4345 which changes some return values.

• create helper functions
• replace assert.True(t, x == y) with assert.Equal(t, x, y)
• Create error types to assert on

This change will make the bulk of CBG-4345 less onerous to read since it will add err to several functions that are used like canSeeChannel and expandWildCardChannel and that would split cause a lot of changes to these test files.

Pre-review checklist

• Removed debug logging (fmt.Print, log.Print, ...)
• Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
• Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

• GSI=true,xattrs=true https://jenkins.sgwdev.com/job/SyncGatewayIntegration/135/

[Copilot]

Pull Request Overview

Refactors authentication test code to prepare for CBG-4345 by improving error handling and test assertions. Key changes include creating structured error types for authorization failures, replacing loose boolean assertions with specific error checking, and introducing helper functions to reduce code duplication.

• Create standardized error types for different authorization failure scenarios
• Replace assert.True(t, x == y) patterns with assert.Equal(t, x, y) for better error messages
• Add helper functions to reduce repetitive test code and improve readability

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
auth/error.go	New file defining structured error types and helper functions for authorization failures
auth/principal.go	Update UnauthError interface to accept error instead of string
auth/role.go	Implement new UnauthError signature and use structured errors
auth/user_collection_access.go	Use new structured error types
auth/role_collection_access.go	Use new structured error types and remove unused imports
db/functions.go	Use structured error with HTTP status code
db/functions/function.go	Use structured error with HTTP status code
auth/collection_access_test.go	Add helper functions and improve test assertions
auth/auth_test.go	Add helper functions and improve test assertions