Skip to content

fix(): resolve issue with <a> tag wrapping for <img> #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(): resolve issue with <a> tag wrapping for <img> #2597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d196fe
fix(): resolve issue with <a> tag wrapping for <img>
njelich Nov 19, 2025
3fe8e43
fix(): add popup class, fix <a> modification
njelich Nov 20, 2025
ef3e538
fix(): remove extra log statement
njelich Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions _includes/refactor-content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,15 @@

{% else %}
<!-- make sure the `<img>` is wrapped by `<a>` -->
{% assign _parent = _right | slice: 1, 4 %}
{% assign _parent = _right | remove_first: ">" | strip | slice: 0, 4 %}

{% if _parent == '</a>' %}
<!-- add class to exist <a> tag -->
{% assign _size = _img_content | size | minus: 1 %}
<!-- add class to existing <a> tag -->
{% assign _size = _img_content | strip | size | minus: 1 %}
{% capture _class %}
class="img-link{% unless _lqip %} shimmer{% endunless %}"
class="popup img-link{% unless _lqip %} shimmer{% endunless %}"
{% endcapture %}
{% assign _img_content = _img_content | slice: 0, _size | append: _class | append: '>' %}
{% assign _img_content = _img_content | strip | slice: 0, _size | append: _class | append: '>' %}

{% else %}
<!-- create the image wrapper -->
Expand Down