Skip to content

[Test]: Should add failure cases for e2e test #297

@cloudgray

Description

@cloudgray

Problem

We need to verify that failed transaction requests return the expected error type and error message.

Closing criteria

For the following cases, when transactions are sent end-to-end (e2e), the JSON-RPC should return the correct error type and hex-encoded data:

Revert Cases

  • Standard contract call
  • Direct precompile call
  • Precompile call via contract

Other Errors (e.g., OutOfGas)

  • Standard contract call
  • Direct precompile call
  • Precompile call via contract

Problem details

A recent PR#289 was created to fix the issue where the revertReason of execRevertError was being returned without JSON hex encoding. This issue occurred due to a partial mistake in PR#224, and could have been caught with e2e tests for revert cases.

Currently, an open e2e test PR#253 adds happy path test cases for precompile calls.
After this is merged, we need to follow up by adding revert test cases for both standard contract calls and precompile calls.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions