Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Justin/rpc #558

Merged
merged 23 commits into from
Oct 1, 2020
Merged

Justin/rpc #558

merged 23 commits into from
Oct 1, 2020

Conversation

@J-Thompson12
Copy link
Contributor

@J-Thompson12 J-Thompson12 commented Sep 30, 2020

Closes: #551
Closes: #553

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

J-Thompson12 and others added 20 commits September 18, 2020 15:13
@J-Thompson12
RPC method docs
001cdc9
@J-Thompson12
forgot readme
7147231
@J-Thompson12
Merge branch 'development' into justin/rpc
e8e5a70
@J-Thompson12
cleanup
72bc1ea
@J-Thompson12
Merge branch 'development' of https://github.com/ChainSafe/ethermint …
0ed54ce 
…into justin/rpc
@J-Thompson12
Merge branch 'justin/rpc' of https://github.com/ChainSafe/ethermint i…
7e6b54f 
…nto justin/rpc
@J-Thompson12
Merge branch 'development' of https://github.com/ChainSafe/ethermint …
fb9ef03 
…into justin/rpc
@J-Thompson12
add table and fill in missing details
92969ec
@fedekunze
update table
5051235
@fedekunze
fix tip block
6a4cd6f
@J-Thompson12
add the rest of the eth methods
5edfb4e
@fedekunze
Merge branch 'development' into justin/rpc
02a3220
@J-Thompson12
Merge branch 'development' of https://github.com/ChainSafe/ethermint …
4912802 
…into justin/rpc
@J-Thompson12
Merge branch 'justin/rpc' of https://github.com/ChainSafe/ethermint i…
84acdd1 
…nto justin/rpc
@J-Thompson12
added the rest of the namespaces
fefabfe
@J-Thompson12
get rid of extra space
e6965e5
@J-Thompson12
merge development
32a549d
@J-Thompson12
Merge branch 'development' of https://github.com/ChainSafe/ethermint …
cfc94ce 
…into justin/rpc
@J-Thompson12
Merge branch 'development' of https://github.com/ChainSafe/ethermint …
fcfe6fb 
…into justin/rpc
@J-Thompson12
doc bug fixes
388fa8a
fedekunze
fedekunze reviewed Oct 1, 2020
View reviewed changes
fedekunze
fedekunze approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze merged commit 3ed790b into development Oct 1, 2020
@fedekunze fedekunze deleted the justin/rpc branch October 1, 2020 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noot noot Awaiting requested review from noot

1 more reviewer

@fedekunze fedekunze fedekunze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Link anchor on rpc docs doenst work "Found a bug link doesn't work" on docs

3 participants

@J-Thompson12 @fedekunze