Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@J-Thompson12
Copy link
Contributor

@J-Thompson12 J-Thompson12 commented Sep 23, 2020

Ref #534
Closes: #495

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @J-Thompson12! I was thinking we could also add a Notes column like the one on this issue #508 to explain why the method doesn't apply

@J-Thompson12
Copy link
Contributor Author

Thats not a bad idea. I would probably just copy the about the call for the rest of them.

@fedekunze fedekunze added the documentation Improvements or additions to documentation label Sep 24, 2020
@J-Thompson12
Copy link
Contributor Author

Thanks I missed that line

@fedekunze fedekunze merged commit b9a10b3 into development Sep 24, 2020
@fedekunze fedekunze deleted the justin/rpc branch September 24, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit JSON-RPC

3 participants