-
Notifications
You must be signed in to change notification settings - Fork 161
RPC method docs #520
RPC method docs #520
Conversation
|
Methods that are missing info eth_getStorageAt need store key eth_sendRawTransaction need to get signed transaction data for param eth_call need toe get a not empty result eth_getTransactionByHash find hash of transaction for param eth_getFilterChanges not empty result eth_getFilterLogs always get error eth_getLogs need not empty result eth_getProof need address store key eth_subscribe and eth_unsubscribe don't know params |
|
@J-Thompson12 it looks like for for for |
|
Thanks Justin! Could you also add a table summary with the name of the method, a namespace column (name of the namespace of the endpoint) and an implemented column (with check) on the top of the doc? |
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @J-Thompson12 for doing this audit!
I think we are missing a few namespaces from the Geth Docs (eg: personal, miner, etc), many of them which don't apply to Etheremint (just stating that would suffice) and some methods from the JSON-RPC Ethereum Wiki (eg: db_, ssh_ and maybe others).
If you want we can merge this PR as is and then open an issue to track the remaining pieces of work that are missing. As you prefer
|
Yeah i learned about those missing ones end of yesterday. It would be good to merge now and i can add the rest today. Colin wants to look at it. |
|
@J-Thompson12 sounds good. Can you create an issue to track the progress? 🙏 |
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Pending follow-up changes
Closes: #https://github.com/ChainSafe/ethermint/issues/495
Description
This is all the rpc methods i could find and get working. I have a list at the bottom i need to format that shows which ones are not implemented or just not important. I also have some where i couldnt get them to work because i dont know the parameter or how to get the parameter.
-->
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)