Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@J-Thompson12
Copy link
Contributor

@J-Thompson12 J-Thompson12 commented Sep 18, 2020

Closes: #https://github.com/ChainSafe/ethermint/issues/495

Description

This is all the rpc methods i could find and get working. I have a list at the bottom i need to format that shows which ones are not implemented or just not important. I also have some where i couldnt get them to work because i dont know the parameter or how to get the parameter.
-->


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@J-Thompson12 J-Thompson12 changed the title RPC method docs WIP: RPC method docs Sep 18, 2020
@J-Thompson12
Copy link
Contributor Author

Methods that are missing info

eth_getStorageAt need store key

eth_sendRawTransaction need to get signed transaction data for param

eth_call need toe get a not empty result

eth_getTransactionByHash find hash of transaction for param

eth_getFilterChanges not empty result

eth_getFilterLogs always get error
{"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"filter 0x35b64c227ce30e84fc5c7bd347be380e doesn't have a LogsSubscription type: got 5"}}

eth_getLogs need not empty result

eth_getProof need address store key

eth_subscribe and eth_unsubscribe don't know params

@noot
Copy link
Contributor

noot commented Sep 21, 2020

@J-Thompson12 it looks like eth_getProof isn't in the ethereum API anymore: https://eth.wiki/json-rpc/API

for eth_getStorageAt, the storage key is the contract address according to the above

for eth_call are you deploying a contract w/ some storage and calling the contract to get that storage? if there is no return value for the tx then the call result will be empty

for eth_subscribe,eth_unsubscribe, eth_getFilterChanges, eth_getFilterLogs, could you try the instructions here and let me know what happens? https://github.com/ChainSafe/ethermint/pull/357

@fedekunze
Copy link
Contributor

Thanks Justin! Could you also add a table summary with the name of the method, a namespace column (name of the namespace of the endpoint) and an implemented column (with check) on the top of the doc?

@J-Thompson12 J-Thompson12 changed the title WIP: RPC method docs RPC method docs Sep 22, 2020
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @J-Thompson12 for doing this audit!

I think we are missing a few namespaces from the Geth Docs (eg: personal, miner, etc), many of them which don't apply to Etheremint (just stating that would suffice) and some methods from the JSON-RPC Ethereum Wiki (eg: db_, ssh_ and maybe others).

If you want we can merge this PR as is and then open an issue to track the remaining pieces of work that are missing. As you prefer

@J-Thompson12
Copy link
Contributor Author

Yeah i learned about those missing ones end of yesterday. It would be good to merge now and i can add the rest today. Colin wants to look at it.

@fedekunze
Copy link
Contributor

@J-Thompson12 sounds good. Can you create an issue to track the progress? 🙏

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending follow-up changes

@fedekunze fedekunze merged commit e3f3619 into development Sep 23, 2020
@fedekunze fedekunze deleted the justin/rpc branch September 23, 2020 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants