fix handler csdb usage, fixes consensus error again

[noot]

Closes: #XXX

Description

fix usage of csdb in handler

to test, start 3 docker nodes as per https://github.com/ChainSafe/ethermint/pull/513

then:

git clone [email protected]:ChainSafe/aragonOS
cd aragonOS

update truffle-config.js to have this as the rpc network:

        rpc: {
            network_id: 17,
            host: '172.17.0.2',
            port: 8545,
            gas: 6.9e6,
            gasPrice: 1,
        },

will likely need to install correct truffle version: npm i -g [email protected]

finally: truffle test test/contracts/apps/app_acl.js --network rpc

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #516 into development will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@               Coverage Diff               @@
##           development     #516      +/-   ##
===============================================
+ Coverage        72.04%   72.08%   +0.04%     
===============================================
  Files               41       41              
  Lines             2719     2723       +4     
===============================================
+ Hits              1959     1963       +4     
  Misses             615      615              
  Partials           145      145              

Impacted Files	Coverage Δ
x/evm/handler.go	91.73% <75.00%> (+0.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244d836...5728eb4. Read the comment docs.

[araskachoi]

no more consensus err

[fedekunze]

LGTM. Minor comment

[fedekunze]

why is this the case?

[noot]

the txCount is used in the stateDB, and since a simulated tx is run only on the node it's submitted to, then this will cause the txCount/stateDB of the node that ran the simulated tx to be different than the other nodes, causing the consensus error

[fedekunze]

ahh great catch! I can we document this on the comments?

[noot]

sure I'll open a follow up with comments!

[fedekunze]

lol, we def need to fix this