Re-implement bip39 #966
Merged
Re-implement bip39 #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should reduce the bundle size a lot as seen in #904: |
|
What else is needed here? Would be great to reduce build size. How best to help get this out of Draft? |
|
This is basically ready. I just got side-tracked and did not consider this a release blocker for 0.27.0. One thing I wanted to add is a pure-js implementation of pbkdf2 in order to support environments that do not have subtle or the Node.js crypto module. But we can also do a cry test and see if someone complains. |
Closed
webmaster128
force-pushed
the
re-implement-bip39
branch
from
7c25d1d to
db1f39e
Compare
webmaster128
force-pushed
the
re-implement-bip39
branch
from
cceefae to
011b00a
Compare
Closed
webmaster128
force-pushed
the
re-implement-bip39
branch
from
011b00a to
0613989
Compare
webmaster128
force-pushed
the
re-implement-bip39
branch
from
0613989 to
656d35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #804 (going back to our own implementation) and inlines much more bip39 functionality.