Skip to content

Conversation

dynst
Copy link
Contributor

@dynst dynst commented Oct 16, 2025

Closes #1721

@webmaster128
Copy link
Member

What's the motivation for this change? We have a perfectly working well tested implementation now and replace it with additional dependencies that potentially cause new trouble later on.

@dynst
Copy link
Contributor Author

dynst commented Oct 16, 2025

I thought replacing custom code with 2 small high quality paulmillr-written packages might ease maintainability similar to the switch to using @scure/bip39, as well as reduce code redundancy in app bundles that already pull in these packages. But good point. Feel free to close this if it's not worth it.

@webmaster128
Copy link
Member

I see. Yeah. But in this case I would lean towards not touch a running system without a need.

There is also another aspect here: it might be worth deprecating and eventually removing slip10 support from CosmJS. This was built for a blockchain in 2018 which used ed25519 HD accounts. However, the entire framework (weave) for buildung those blockchain is long dead. I never saw ed25519 keypairs for user accounts in Cosmos SDK based chains and cosmos/cosmos-sdk#8543 seems to be going nowhere. So we can as well ditch the slip10 part to simplify that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecating bip39 & bip32 code

2 participants