Package code in the dist/ directory #1854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dist/ is the universal convention for actually distributing the library. build/ for temporary build artifacts for tests.
|
Why is "dist" better than "build"? Isn't is confusing to write all build artifacts into a "distribution" folder including those that should never be distributed like tests? |
|
|
||
| // list of files / patterns to load in the browser | ||
| files: ["dist/web/tests.js"], | ||
| files: ["build/web/tests.js"], |
There was a problem hiding this comment.
I like this change btw. As this is a purely dev build artifact, we can bundle from build/ to build/web/ or something like that to free the "dist" name
|
I just merged the SKIP_BUILD change to main as it is a nice improvement independent of the rest of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And silence a warning about an unbound variable.
Split out of #1833 without transpiler changes.