Update version support in setup.cfg #340
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects Python version support to reflect the metadata for the package. Specifically it removes the previous configuration that was still building wheels for Python 2 even though Python 2 support has been dropped.
kurtmckee
approved these changes
Mar 22, 2024
|
@corydolphin Thanks for releasing v5! Please review this PR when you have an opportunity. There are several other PRs that can probably merge in a matter of minutes, too! 👍 |
|
I seem to be stuck a bit here too - I can see support for py3.7 is dropped (tests removed and release notes say py3.8+ is supported now), but there is no So, I am not sure if 5.0 is supposed to work on py3.7 or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the configuration to correctly reflect supported Python versions. This includes removing the option that was still building wheels for Python 2 even though Python 2 support has been dropped and adding a Python version requirement that matches the metadata described in
setup.py. This should resolve #339.