merge Prometheus metrics for removed user to avoid having to recompute metrics from scratch everytime #4813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e metrics from scratch everytime Signed-off-by: Roy Chiang <[email protected]>
roystchiang
force-pushed
the
attemp-to-fix-leak-v2
branch
2 times, most recently
from
46f0266 to
4676f74
Compare
Signed-off-by: Roy Chiang <[email protected]>
roystchiang
force-pushed
the
attemp-to-fix-leak-v2
branch
from
4676f74 to
148c1e7
Compare
alanprot
approved these changes
Aug 8, 2022
alvinlin123
approved these changes
Aug 9, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roy Chiang [email protected]
What this PR does:
When a user is removed, instead of keeping the registry in memory, we now merge all the gathered metrics. This helps to avoid the build up of registries(memory leak), and speeds up the computation of metrics.
Which issue(s) this PR fixes:
Fixes #4451
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]