Skip to content

Bring your own package #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 15, 2019
Merged

Bring your own package #5

merged 14 commits into from
Feb 15, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Feb 5, 2019 •
edited
Loading

Checklist:

  • Test end to end manually (e.g. rebuild registry/operator and run cx refresh in an example folder)
  • Run automated tests (./build/test.sh)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick bugfixes into release branches
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu February 5, 2019 02:08
deliahu
deliahu requested changes Feb 5, 2019
View reviewed changes
deliahu
deliahu reviewed Feb 7, 2019
View reviewed changes
deliahu
deliahu approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalbollu vishalbollu merged commit f3df21a into master Feb 15, 2019
@vishalbollu vishalbollu deleted the bring-your-own-package branch February 15, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@ospillinger ospillinger Awaiting requested review from ospillinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu