Skip to content

Cortex support #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 30, 2019
Merged

Cortex support #491

merged 9 commits into from
Sep 30, 2019

Conversation

vishalbollu
Copy link
Contributor

Closes #


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu September 27, 2019 16:10
var supportCmd = &cobra.Command{
Use: "support",
Short: "request support from cortex developers",
Long: `
This command sends a support request to Cortex developers.`,
Run: func(cmd *cobra.Command, args []string) {
support := &Support{}
err := cr.ReadPrompt(support, getSupportRequest())
support := &SupportRequest{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe supportRequest

@@ -90,10 +90,10 @@ This command sends a support request to Cortex maintainers.`,
defer resp.Body.Close()

if resp.StatusCode < 200 || resp.StatusCode >= 300 {
fmt.Println("Thanks for letting us know, we will get back to you soon at " + support.EmailAddress)
fmt.Println("Failed to send request, please file an issue on GitHub: https://github.com/cortexlabs/cortex")
Copy link
Member

@deliahu deliahu Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Failed to send request, please file an issue on GitHub (https://github.com/cortexlabs/cortex) or email us at [email protected]"

@vishalbollu vishalbollu merged commit 5878bff into master Sep 30, 2019
@vishalbollu vishalbollu deleted the cx-support branch September 30, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants