Skip to content

Remove verbose flag #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Remove verbose flag #400

merged 4 commits into from
Aug 29, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Aug 29, 2019

Closes #391


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu August 29, 2019 17:52
"An error occurred, see `cortex logs -v api {}` for more details.".format(
api["name"]
)
"An error occurred, see `cortex logs api {}` for more details.".format(api["name"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this error message necessary, or do you think we should remove it entirely? Will the user see this error message if they aren't already looking at the logs? (same question for all "An error occurred..." messages)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@vishalbollu vishalbollu merged commit f624d42 into master Aug 29, 2019
@vishalbollu vishalbollu deleted the remove-verbose-flag-logs branch August 29, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove verbose logs flag
2 participants