Skip to content

Remove sample and prediction key #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Conversation

vishalbollu
Copy link
Contributor

Closes #389


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu August 29, 2019 13:08
@@ -165,10 +165,13 @@ def convert_to_onnx_input(sample, input_metadata_list):

@app.route("/<app_name>/<api_name>", methods=["POST"])
def predict(app_name, api_name):
debug = request.args.get("debug").lower() == "true"
debug = (
request.args.get("debug", "false") is not None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "false" necessary?

@vishalbollu vishalbollu merged commit c72cead into master Aug 30, 2019
@vishalbollu vishalbollu deleted the remove-samples-predictions-key branch August 30, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove samples and predictions from API schema
2 participants