Skip to content

http default support #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2019
Merged

http default support #350

merged 4 commits into from
Aug 19, 2019

Conversation

1vn
Copy link
Contributor

@1vn 1vn commented Aug 19, 2019

Closes #327


Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@@ -635,7 +635,7 @@ func APIsBaseURL() (string, error) {
if len(service.Status.LoadBalancer.Ingress) == 0 {
return "", ErrorLoadBalancerInitializing()
}
return "https://" + service.Status.LoadBalancer.Ingress[0].Hostname, nil
return "http://" + service.Status.LoadBalancer.Ingress[0].Hostname, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tell you somewhere in the docs that you can use https (and that it will use a cert that we generated on install), can you add that? Omer should have an opinion on where to add it in the docs.

@deliahu deliahu merged commit 69938bc into master Aug 19, 2019
@deliahu deliahu deleted the http branch August 19, 2019 22:18
deliahu pushed a commit that referenced this pull request Aug 20, 2019
(cherry picked from commit 69938bc)
deliahu added a commit that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use HTTP by default for APIs
2 participants