Skip to content

Make the node groups selector part of the API spec ID #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2021
Merged

Make the node groups selector part of the API spec ID #2354

merged 1 commit into from
Jul 17, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 17, 2021 •
edited
Loading

Without this, running a cortex deploy <api-name> on an existing API that has had the node_groups section updated won't get updated.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Jul 17, 2021
@RobertLucian RobertLucian requested a review from deliahu July 17, 2021 03:24
@RobertLucian RobertLucian merged commit 7e7fabc into master Jul 17, 2021
@RobertLucian RobertLucian deleted the fix/api-node-groups-update branch July 17, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @deliahu