Skip to content

Add prod recommendations and migrating guide #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 14, 2021
Merged

Add prod recommendations and migrating guide #2334

merged 15 commits into from
Jul 14, 2021

Conversation

vishalbollu
Copy link
Contributor

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

miguelvr
miguelvr reviewed Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos I spotted:

loadbalancer(s) → load balancer(s)
nodegroup(s) → node group(s)
scale ups → scale-ups
setup → set up
healthchecks → health checks

miguelvr
miguelvr reviewed Jul 13, 2021
View reviewed changes
miguelvr
miguelvr reviewed Jul 13, 2021
View reviewed changes
miguelvr
miguelvr reviewed Jul 13, 2021
View reviewed changes
miguelvr
miguelvr reviewed Jul 13, 2021
View reviewed changes
@vishalbollu vishalbollu merged commit b272a63 into master Jul 14, 2021
@vishalbollu vishalbollu deleted the prod-docs branch July 14, 2021 06:53
miguelvr pushed a commit that referenced this pull request Jul 19, 2021
@vishalbollu
Add prod recommendations and migrating guide (#2334)
24ddab4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr left review comments

@deliahu deliahu deliahu approved these changes

@ospillinger ospillinger Awaiting requested review from ospillinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalbollu @deliahu @miguelvr