Skip to content

Fix async api responses' statuses (status would be stuck in in_queue state) #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 12, 2021
Merged

Fix async api responses' statuses (status would be stuck in in_queue state) #2072

merged 12 commits into from
Apr 12, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Apr 10, 2021 •
edited
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the bug Something isn't working label Apr 10, 2021
@RobertLucian RobertLucian changed the title Fix async api responses' statuses (status would never change from in_queue) Fix async api responses' statuses (status would be stuck in in_queue state) Apr 10, 2021
miguelvr
miguelvr reviewed Apr 10, 2021
View reviewed changes
miguelvr
miguelvr reviewed Apr 10, 2021
View reviewed changes
deliahu
deliahu reviewed Apr 11, 2021
View reviewed changes
miguelvr
miguelvr reviewed Apr 12, 2021
View reviewed changes
miguelvr
miguelvr reviewed Apr 12, 2021
View reviewed changes
miguelvr
miguelvr approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, but otherwise LGMT

@RobertLucian RobertLucian merged commit 6336187 into master Apr 12, 2021
@RobertLucian RobertLucian deleted the async-individual-status-files branch April 12, 2021 17:21
@miguelvr miguelvr mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

@vishalbollu vishalbollu Awaiting requested review from vishalbollu

@deliahu deliahu Awaiting requested review from deliahu

Assignees

@vishalbollu vishalbollu

@RobertLucian RobertLucian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobertLucian @deliahu @miguelvr @vishalbollu