Skip to content

Fix loop pointer references #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 19, 2021
Merged

Fix loop pointer references #1982

merged 8 commits into from
Mar 19, 2021

Conversation

miguelvr
Copy link
Collaborator

@miguelvr miguelvr commented Mar 19, 2021 •
edited
Loading

Summary:

  • Added looppointer to the CI linters
  • Fixed or ignored all the warnings

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@miguelvr miguelvr requested a review from vishalbollu March 19, 2021 11:37
@miguelvr miguelvr changed the title Fix saving pointer reference in for/range loop Fix loop pointer references Mar 19, 2021
@miguelvr miguelvr merged commit 971a091 into master Mar 19, 2021
@miguelvr miguelvr deleted the fix/pointer-loops branch March 19, 2021 16:32
vishalbollu added a commit that referenced this pull request Mar 22, 2021
@vishalbollu
Fix loop pointer references (#1982)
1696fe7 
* Fix saving pointer reference in for/range loop

* Fix or ignore looppointer warnings

* Add looppointer to lint.sh and tools

* Fix looppointer ignores

* Update circleci config.yml

* Propagate non-zero exit code

* Remove nolint:looppointer labels

Co-authored-by: vishal <[email protected]>
Co-authored-by: Vishal Bollu <[email protected]>
(cherry picked from commit 971a091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelvr @vishalbollu