Update Cortex to be installable on any k8s cluster on AWS and GCP #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelvr
reviewed
Feb 1, 2021
miguelvr
reviewed
Feb 1, 2021
deliahu
reviewed
Feb 1, 2021
pkg/operator/config/config.go
Outdated
| OperatorMetadata *clusterconfig.OperatorMetadata | ||
|
|
||
| Cluster *clusterconfig.BaseConfig | ||
| fullClusterConfig *clusterconfig.InternalConfig |
pkg/operator/config/config.go
Outdated
| Cluster *clusterconfig.BaseConfig | ||
| fullClusterConfig *clusterconfig.InternalConfig | ||
| GCPCluster *clusterconfig.GCPBaseConfig | ||
| gcpFullClusterConfig *clusterconfig.InternalGCPConfig |
pkg/operator/config/config.go
Outdated
| return err | ||
| } | ||
| if !exists { | ||
| return errors.ErrorUnexpected("the specified bucket either does not exist", gcpFullClusterConfig.Bucket) |
pkg/operator/config/config.go
Outdated
Comment on lines
188
to
194
| if gcpFullClusterConfig.Bucket == "" { | ||
| gcpFullClusterConfig.Bucket = clusterconfig.GCPBucketName(gcpFullClusterConfig.ClusterName, *gcpFullClusterConfig.Project, *gcpFullClusterConfig.Zone) | ||
| err := GCP.CreateBucket(gcpFullClusterConfig.Bucket, gcp.ZoneToRegion(*gcpFullClusterConfig.Zone), true) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
deliahu
approved these changes
Feb 2, 2021
miguelvr
reviewed
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1808
checklist:
make testandmake lintsummary.md(view in gitbook after merging)