Skip to content

Support GCP instances with multiple GPUs #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 18, 2021
Merged

Support GCP instances with multiple GPUs #1789

merged 6 commits into from
Jan 18, 2021

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Jan 15, 2021

closes #1784

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian self-requested a review January 16, 2021 00:19
RobertLucian
RobertLucian approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For reference, in the GCP validation on master, we don't yet validate for the number of accelerators, so this PR is good in this regard.

@deliahu deliahu merged commit 577861b into master Jan 18, 2021
@deliahu deliahu deleted the gcp-multi-gpu branch January 18, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP - support instances with multiple GPUs
2 participants
@deliahu @RobertLucian