Add ability to sample dataset #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deliahu
requested changes
Feb 14, 2019
pkg/workloads/spark_job/spark_job.py
Outdated
| if max_rows == full_dataset_size: | ||
| return ingest_df | ||
| if subset_config["shuffle"]: | ||
| ingest_df = ingest_df.sample(fraction=fraction, seed=subset_config["seed"]) |
There was a problem hiding this comment.
As discussed, research if using fraction=1.0 reduces efficiency. If it does hurt, we should either bump the fraction a little to avoid undersampling, or add the word "roughly" in the docs. If it does work, then the logger.info below doesn't need "at most" :)
There was a problem hiding this comment.
Added an extra buffer to sampling but I think we should still have at most to cover randomness
vishalbollu
force-pushed
the
small-dataset
branch
from
0b57993 to
8514887
Compare
vishalbollu
force-pushed
the
small-dataset
branch
from
e7c31f5 to
643dddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
cx refreshin an example folder)./build/test.sh)cx init