Skip to content

Fix configreader struct nil handling #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2019
Merged

Fix configreader struct nil handling #106

merged 2 commits into from
May 24, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented May 24, 2019 •
edited
Loading

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu May 24, 2019 06:35
vishalbollu
vishalbollu reviewed May 24, 2019
View reviewed changes
pkg/lib/configreader/reader_test.go Outdated
Key1: nil,
Key2: nil,
Key3: nil,
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

vishalbollu
vishalbollu reviewed May 24, 2019
View reviewed changes
pkg/lib/configreader/reader_test.go Outdated
}
testConfig(structValidation, configDataParentNullValues, expected, t)

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

vishalbollu
vishalbollu approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deliahu deliahu merged commit 92d7689 into master May 24, 2019
@deliahu deliahu deleted the configreader-nil branch May 24, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deliahu @vishalbollu