-
Notifications
You must be signed in to change notification settings - Fork 949
fix: update dependency cosmiconfig to v8.3.6 - autoclosed #3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e4525d4 to
e032bec
Compare
f35dcd2 to
3d5eb3f
Compare
3d5eb3f to
d309fdf
Compare
c5d24e9 to
9d0ad41
Compare
9d0ad41 to
23487b2
Compare
|
Tried something before here: #3623 |
23487b2 to
c59b297
Compare
|
@escapedcat I think I figured this out: There's an issue with node < 20.8.0 where async/await imports cause a segmentation fault for some reason (got exit code 139 after running the test locally): nodejs/node#40058 (resolved in: nodejs/node#48510 ). It looks like the node 20 check is using node 20.5.x which is why it's failing. If you look in src/loader.js (https://github.com/cosmiconfig/cosmiconfig/compare/v8.1.3...v8.2.0?short_path=06572a9#diff-e06cc0643d5d32542b35abf16a4c938570ddd0a6d2fb52cc1703b45635e2cb8bR20) you'll notice that the async version of 'loadJs' uses the dynamic import syntax starting in v8.2.0, which aligns with the node issue above. The fix for this was either to instead use the cosmiconfigSync method, or replace all of the js loaders with the sync versions (the js one is the only one actually impacting the tests though since mjs/cjs aren't tested): Also, the skipped test in load.test.js is failing because the extends in @commitlint/load/fixtures/recursive-extends-ts need to be suffixed with '/index.ts'; require isn't automatically resolving the index.ts as the default path when given the directory. I tried seeing if I could address this with some changes to the commitlint/load tsconfig but didn't have any luck. |
|
Wow, nice digging! Thanks @joberstein
I guess eventually the actions will use 20.8.0 and tests might turn green. That would be great. We can postpone cosmicconfig update till then. |
|
@escapedcat do you want me to update the JS loaders? It's supposed to be the same functionality, and it would allow support for mjs too in the meantime. |
Sure, happy if you want to give this a try |
This PR contains the following updates:
8.1.3->8.3.6Release Notes
cosmiconfig/cosmiconfig (cosmiconfig)
v8.3.6Compare Source
Bug Fixes
v8.3.5Compare Source
Bug Fixes
v8.3.4Compare Source
Bug Fixes
v8.3.3Compare Source
Bug Fixes
v8.3.2Compare Source
Bug Fixes
.cjsextension for sync compiled typescript (0d76a9a)v8.3.1Compare Source
Bug Fixes
stopDirwhen undefined (59082e2), closes #317v8.3.0Compare Source
Features
v8.2.0Compare Source
.mjsfiles, or.jsfiles whose nearest parentpackage.jsonfile contains"type": "module".${moduleName}rc.mjsand${moduleName}.config.mjsare included in the defaultsearchPlacesof the asynchronous API..mjsfiles.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.